dsa: Split ops up, and avoid assigning tag_protocol and receive separately
authorAlexander Duyck <alexander.h.duyck@intel.com>
Mon, 15 Sep 2014 17:00:19 +0000 (13:00 -0400)
committerDavid S. Miller <davem@davemloft.net>
Mon, 15 Sep 2014 21:24:20 +0000 (17:24 -0400)
commit5075314e4e4b559cc37675ad8a721a89bccd6284
tree37d72bc57dd16717b15acbb14e5c98e7d36ced19
parent6cca9adb786184be21f30be0982e3ea0281f75cb
dsa: Split ops up, and avoid assigning tag_protocol and receive separately

This change addresses several issues.

First, it was possible to set tag_protocol without setting the ops pointer.
To correct that I have reordered things so that rcv is now populated before
we set tag_protocol.

Second, it didn't make much sense to keep setting the device ops each time a
new slave was registered.  So by moving the receive portion out into root
switch initialization that issue should be addressed.

Third, I wanted to avoid sending tags if the rcv pointer was not registered
so I changed the tag check to verify if the rcv function pointer is set on
the root tree.  If it is then we start sending DSA tagged frames.

Finally I split the device ops pointer in the structures into two spots.  I
placed the rcv function pointer in the root switch since this makes it
easiest to access from there, and I placed the xmit function pointer in the
slave for the same reason.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/netdevice.h
include/net/dsa.h
net/dsa/dsa.c
net/dsa/dsa_priv.h
net/dsa/slave.c
net/dsa/tag_brcm.c
net/dsa/tag_dsa.c
net/dsa/tag_edsa.c
net/dsa/tag_trailer.c