lwtunnel: fix error path in lwtunnel_fill_encap()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 28 Apr 2017 13:03:48 +0000 (16:03 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 1 May 2017 02:41:29 +0000 (22:41 -0400)
commit39f37095990a39a0ee24f7621d06e9a6da6cd815
tree7925780e45f5ad3dc62a5b016b148aefd53f15d9
parent77041e89ce3d4efb9e2364b6d27e97d4bbca74fc
lwtunnel: fix error path in lwtunnel_fill_encap()

We recently added a check to see if nla_nest_start() fails.  There are
two issues with that.  First, if it fails then I don't think we should
call nla_nest_cancel().  Second, it's slightly convoluted but the
current code returns success but we should return -EMSGSIZE instead.

Fixes: a50fe0ffd76f ("lwtunnel: check return value of nla_nest_start")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: David Ahern <dsa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/lwtunnel.c