net: remove newlines in NL_SET_ERR_MSG_MOD
authorJacob Keller <jacob.e.keller@intel.com>
Thu, 7 May 2020 00:58:27 +0000 (17:58 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 8 May 2020 00:56:14 +0000 (17:56 -0700)
commitc75a33c84b83ffbb8b8b58a6bf4dea69dba21326
tree6d40ec96ba57913618c4fd0553fa37873361d55a
parent57ea85069cc5da0e8b8418f901cae706f92774fb
net: remove newlines in NL_SET_ERR_MSG_MOD

The NL_SET_ERR_MSG_MOD macro is used to report a string describing an
error message to userspace via the netlink extended ACK structure. It
should not have a trailing newline.

Add a cocci script which catches cases where the newline marker is
present. Using this script, fix the handful of cases which accidentally
included a trailing new line.

I couldn't figure out a way to get a patch mode working, so this script
only implements context, report, and org.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Andy Whitcroft <apw@canonical.com>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
drivers/net/ethernet/mscc/ocelot_tc.c
net/bridge/br_mrp_netlink.c
net/bridge/br_stp_if.c
net/dsa/slave.c
scripts/coccinelle/misc/newline_in_nl_msg.cocci [new file with mode: 0644]