rhashtable: don't allocate ht structure on stack in test_rht_init
authorDaniel Borkmann <daniel@iogearbox.net>
Fri, 20 Feb 2015 20:14:21 +0000 (21:14 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 20 Feb 2015 21:33:30 +0000 (16:33 -0500)
commitb7f5e5c7f8cedf6b69c9702d448cdf78ffc45c7b
tree7095dd91e8b9ff77264951ac27f1f756e9622bf5
parentbf60e50cb3ed50ae536f7655c8af1acda137ea5b
rhashtable: don't allocate ht structure on stack in test_rht_init

With object runtime debugging enabled, the rhashtable test suite
will rightfully throw a warning "ODEBUG: object is on stack, but
not annotated" from rhashtable_init().

This is because run_work is (correctly) being initialized via
INIT_WORK(), and not annotated by INIT_WORK_ONSTACK(). Meaning,
rhashtable_init() is okay as is, we just need to move ht e.g.,
into global scope.

It never triggered anything, since test_rhashtable is rather a
controlled environment and effectively runs to completion, so
that stack memory is not vanishing underneath us, we shouldn't
confuse any testers with it though.

Fixes: 7e1e77636e36 ("lib: Resizable, Scalable, Concurrent Hash Table")
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
lib/test_rhashtable.c