fix short copy handling in copy_mc_pipe_to_iter()
authorAl Viro <viro@zeniv.linux.org.uk>
Sun, 12 Jun 2022 23:50:29 +0000 (19:50 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Tue, 28 Jun 2022 21:37:11 +0000 (17:37 -0400)
commitc3497fd009ef2c59eea60d21c3ac22de3585ed7d
tree7276b6fd06564aec5776158a674e5bfbbd45d453
parentb13baccc3850ca8b8cccbf8ed9912dbaa0fdf7f3
fix short copy handling in copy_mc_pipe_to_iter()

Unlike other copying operations on ITER_PIPE, copy_mc_to_iter() can
result in a short copy.  In that case we need to trim the unused
buffers, as well as the length of partially filled one - it's not
enough to set ->head, ->iov_offset and ->count to reflect how
much had we copied.  Not hard to fix, fortunately...

I'd put a helper (pipe_discard_from(pipe, head)) into pipe_fs_i.h,
rather than iov_iter.c - it has nothing to do with iov_iter and
having it will allow us to avoid an ugly kludge in fs/splice.c.
We could put it into lib/iov_iter.c for now and move it later,
but I don't see the point going that way...

Cc: stable@kernel.org # 4.19+
Fixes: ca146f6f091e "lib/iov_iter: Fix pipe handling in _copy_to_iter_mcsafe()"
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Christian Brauner (Microsoft) <brauner@kernel.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
include/linux/pipe_fs_i.h
lib/iov_iter.c