workqueue: Avoid using isolated cpus' timers on queue_delayed_work
authorLeonardo Bras <leobras@redhat.com>
Tue, 30 Jan 2024 01:00:46 +0000 (22:00 -0300)
committerTejun Heo <tj@kernel.org>
Tue, 30 Jan 2024 01:21:37 +0000 (15:21 -1000)
commitaae17ebb53cd3da37f5dfbde937acd091eb4340c
tree515cc96445c69fed09c1e8363c51d2e478c892ca
parent07daa99b7fd7adfffa22180184e39ec124e73013
workqueue: Avoid using isolated cpus' timers on queue_delayed_work

When __queue_delayed_work() is called, it chooses a cpu for handling the
timer interrupt. As of today, it will pick either the cpu passed as
parameter or the last cpu used for this.

This is not good if a system does use CPU isolation, because it can take
away some valuable cpu time to:
1 - deal with the timer interrupt,
2 - schedule-out the desired task,
3 - queue work on a random workqueue, and
4 - schedule the desired task back to the cpu.

So to fix this, during __queue_delayed_work(), if cpu isolation is in
place, pick a random non-isolated cpu to handle the timer interrupt.

As an optimization, if the current cpu is not isolated, use it instead
of looking for another candidate.

Signed-off-by: Leonardo Bras <leobras@redhat.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/workqueue.c