taskstats: fill_stats_for_tgid: use for_each_thread()
authorOleg Nesterov <oleg@redhat.com>
Sat, 9 Sep 2023 21:49:51 +0000 (23:49 +0200)
committerAndrew Morton <akpm@linux-foundation.org>
Wed, 4 Oct 2023 17:41:57 +0000 (10:41 -0700)
commited5378a387fd7c382497f2abcf4605e030b64044
treebfe39f3100e0e514c46fc189b11d56b6bdbde892
parent13b7bc60b5353371460a203df6c38ccd38ad7a3a
taskstats: fill_stats_for_tgid: use for_each_thread()

do/while_each_thread should be avoided when possible.

Plus I _think_ this change allows to avoid lock_task_sighand() but I am
not sure, I forgot everything about taskstats.  In any case, this code
does not look right in that the same thread can be accounted twice:
taskstats_exit() can account the exiting thread in signal->stats and drop
->siglock but this thread is still on the thread-group list, so
lock_task_sighand() can't help.

Link: https://lkml.kernel.org/r/20230909214951.GA24274@redhat.com
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
kernel/taskstats.c