kallsyms: Replace all non-returning strlcpy with strscpy
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Wed, 14 Jun 2023 01:03:54 +0000 (01:03 +0000)
committerKees Cook <keescook@chromium.org>
Wed, 14 Jun 2023 19:27:38 +0000 (12:27 -0700)
commit33457938a0c4e817ab6f9923e244b91289f47f54
tree69141c2bb53aff72f2bb0475bd7fc01f566cfa9c
parent870410910b6ad032afb6a02bfd6a8c65dde6084b
kallsyms: Replace all non-returning strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230614010354.1026096-1-azeemshaikh38@gmail.com
kernel/kallsyms.c
kernel/params.c