locking/rtmutex: Use try_cmpxchg_relaxed() in mark_rt_mutex_waiters()
authorUros Bizjak <ubizjak@gmail.com>
Wed, 24 Jan 2024 10:49:53 +0000 (11:49 +0100)
committerIngo Molnar <mingo@kernel.org>
Fri, 1 Mar 2024 12:02:05 +0000 (13:02 +0100)
commitce3576ebd62d99f79c1dc98824e2ef6d6ab68434
treeff97be9bf28a71d1b790982c793ebbe8591c7695
parente807c2a37044a51de89d6d4f8a1f5ecfb3752f36
locking/rtmutex: Use try_cmpxchg_relaxed() in mark_rt_mutex_waiters()

Use try_cmpxchg() instead of cmpxchg(*ptr, old, new) == old.

The x86 CMPXCHG instruction returns success in the ZF flag, so this change
saves a compare after CMPXCHG (and related move instruction in front of CMPXCHG).

Also, try_cmpxchg() implicitly assigns old *ptr value to "old" when CMPXCHG
fails. There is no need to re-read the value in the loop.

Note that the value from *ptr should be read using READ_ONCE() to prevent
the compiler from merging, refetching or reordering the read.

No functional change intended.

Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Waiman Long <longman@redhat.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul E. McKenney <paulmck@kernel.org>
Link: https://lore.kernel.org/r/20240124104953.612063-1-ubizjak@gmail.com
kernel/locking/rtmutex.c