locking/lockdep: Fix the rollback and overwrite detection logic in crossrelease
authorByungchul Park <byungchul.park@lge.com>
Mon, 14 Aug 2017 07:00:52 +0000 (16:00 +0900)
committerIngo Molnar <mingo@kernel.org>
Mon, 14 Aug 2017 10:52:17 +0000 (12:52 +0200)
commit907dc16d7e23ec81a126c9585435494fa1b3a4b7
tree31b53da542b0fa6cb863c06a39daeed055372acb
parenta10b5c564741cd3b6708f085a1fa892b63c2063d
locking/lockdep: Fix the rollback and overwrite detection logic in crossrelease

As Boqun Feng pointed out, current->hist_id should be aligned with the
latest valid xhlock->hist_id so that hist_id_save[] storing current->hist_id
can be comparable with xhlock->hist_id. Fix it.

Additionally, the condition for overwrite-detection should be the
opposite. Fix the code and the comments as well.

           <- direction to visit
hhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh (h: history)
                 ^^        ^
                 ||        start from here
                 |previous entry
                 current entry

Reported-by: Boqun Feng <boqun.feng@gmail.com>
Signed-off-by: Byungchul Park <byungchul.park@lge.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: akpm@linux-foundation.org
Cc: kernel-team@lge.com
Cc: kirill@shutemov.name
Cc: linux-mm@kvack.org
Cc: npiggin@gmail.com
Cc: walken@google.com
Cc: willy@infradead.org
Link: http://lkml.kernel.org/r/1502694052-16085-3-git-send-email-byungchul.park@lge.com
[ Improve the comments some more. ]
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/locking/lockdep.c