futex: Fix (possible) missed wakeup
authorPeter Zijlstra <peterz@infradead.org>
Thu, 29 Nov 2018 13:44:49 +0000 (14:44 +0100)
committerIngo Molnar <mingo@kernel.org>
Mon, 21 Jan 2019 10:15:38 +0000 (11:15 +0100)
commitb061c38bef43406df8e73c5be06cbfacad5ee6ad
treec031de9bb7878fd8a24cc0fb339151044e2fae12
parent4c4e3731564c8945ac5ac90fc2a1e1f21cb79c92
futex: Fix (possible) missed wakeup

We must not rely on wake_q_add() to delay the wakeup; in particular
commit:

  1d0dcb3ad9d3 ("futex: Implement lockless wakeups")

moved wake_q_add() before smp_store_release(&q->lock_ptr, NULL), which
could result in futex_wait() waking before observing ->lock_ptr ==
NULL and going back to sleep again.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: 1d0dcb3ad9d3 ("futex: Implement lockless wakeups")
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/futex.c