exit: Move preemption fixup up, move blocking operations down
authorJann Horn <jannh@google.com>
Thu, 5 Mar 2020 22:06:57 +0000 (23:06 +0100)
committerPeter Zijlstra <peterz@infradead.org>
Thu, 30 Apr 2020 18:14:38 +0000 (20:14 +0200)
commit586b58cac8b4683eb58a1446fbc399de18974e40
treea31aa2ff43c541f2ee7d098369379effb2ffffe4
parent64297f2b03cc7a6d0184a435f1b296beca1bedd1
exit: Move preemption fixup up, move blocking operations down

With CONFIG_DEBUG_ATOMIC_SLEEP=y and CONFIG_CGROUPS=y, kernel oopses in
non-preemptible context look untidy; after the main oops, the kernel prints
a "sleeping function called from invalid context" report because
exit_signals() -> cgroup_threadgroup_change_begin() -> percpu_down_read()
can sleep, and that happens before the preempt_count_set(PREEMPT_ENABLED)
fixup.

It looks like the same thing applies to profile_task_exit() and
kcov_task_exit().

Fix it by moving the preemption fixup up and the calls to
profile_task_exit() and kcov_task_exit() down.

Fixes: 1dc0fffc48af ("sched/core: Robustify preemption leak checks")
Signed-off-by: Jann Horn <jannh@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20200305220657.46800-1-jannh@google.com
kernel/exit.c