genirq: Get rid of unnecessary IRQTF_DIED flag
authorAlexander Gordeev <agordeev@redhat.com>
Fri, 9 Mar 2012 13:59:59 +0000 (14:59 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Fri, 9 Mar 2012 16:19:09 +0000 (17:19 +0100)
commit5234ffb9f74cfa8993d174782bc861dd9b7b5bfb
treec3933cd6177cde81a99f0bcdadb333b1233e007d
parent05d74efa3c72a5c40b0edeb15856c0230126313b
genirq: Get rid of unnecessary IRQTF_DIED flag

Currently IRQTF_DIED flag is set when a IRQ thread handler calls do_exit()
But also PF_EXITING per process flag gets set when a thread exits. This
fix eliminates the duplicate by using PF_EXITING flag.

Also, there is a race condition in exit_irq_thread(). In case a thread's
bit is cleared in desc->threads_oneshot (and the IRQ line gets unmasked),
but before IRQTF_DIED flag is set, a new interrupt might come in and set
just cleared bit again, this time forever. This fix throws IRQTF_DIED flag
away, eliminating the race as a result.

[ tglx: Test THREAD_EXITING first as suggested by Oleg ]

Reported-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Link: http://lkml.kernel.org/r/20120309135958.GD2114@dhcp-26-207.brq.redhat.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
kernel/exit.c
kernel/irq/handle.c
kernel/irq/internals.h
kernel/irq/manage.c