cpu/hotplug: Remove the 'cpu' member of cpuhp_cpu_state
authorSteven Price <steven.price@arm.com>
Mon, 11 Apr 2022 15:22:32 +0000 (16:22 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 13 Apr 2022 19:25:40 +0000 (21:25 +0200)
commitb7ba6d8dc3569e49800ef0136799f26f43e237e8
tree471096212904c8a757af531fe7fca1781cf59109
parent9e949a3886356fe9112c6f6f34a6e23d1d35407f
cpu/hotplug: Remove the 'cpu' member of cpuhp_cpu_state

Currently the setting of the 'cpu' member of struct cpuhp_cpu_state in
cpuhp_create() is too late as it is used earlier in _cpu_up().

If kzalloc_node() in __smpboot_create_thread() fails then the rollback will
be done with st->cpu==0 causing CPU0 to be erroneously set to be dying,
causing the scheduler to get mightily confused and throw its toys out of
the pram.

However the cpu number is actually available directly, so simply remove
the 'cpu' member and avoid the problem in the first place.

Fixes: 2ea46c6fc945 ("cpumask/hotplug: Fix cpu_dying() state tracking")
Signed-off-by: Steven Price <steven.price@arm.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20220411152233.474129-2-steven.price@arm.com
kernel/cpu.c