bpf: verifier: avoid fall-through warnings
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Thu, 11 Jul 2019 16:22:33 +0000 (11:22 -0500)
committerDaniel Borkmann <daniel@iogearbox.net>
Fri, 12 Jul 2019 13:13:20 +0000 (15:13 +0200)
commited4ed4043a127c5ca9a35339bb614693be9037a3
tree688b04add07b6347f2a05cb73f85f0a22afc72c2
parent59d82657a08d4a9e6e2d99acc525ef748d36016b
bpf: verifier: avoid fall-through warnings

In preparation to enabling -Wimplicit-fallthrough, this patch silences
the following warning:

kernel/bpf/verifier.c: In function ‘check_return_code’:
kernel/bpf/verifier.c:6106:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
   if (env->prog->expected_attach_type == BPF_CGROUP_UDP4_RECVMSG ||
      ^
kernel/bpf/verifier.c:6109:2: note: here
  case BPF_PROG_TYPE_CGROUP_SKB:
  ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

Notice that is much clearer to explicitly add breaks in each case
statement (that actually contains some code), rather than letting
the code to fall through.

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Andrii Nakryiko <andriin@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
kernel/bpf/verifier.c