bpf: Check for helper calls in check_subprogs()
authorIlya Leoshkevich <iii@linux.ibm.com>
Mon, 20 Feb 2023 16:37:56 +0000 (17:37 +0100)
committerAlexei Starovoitov <ast@kernel.org>
Wed, 22 Feb 2023 21:08:52 +0000 (13:08 -0800)
commitdf2ccc180a2e6f6e4343ebee99dcfab4f8af2816
tree322f1895b986f7b8d04bc9126c36a678727c2c49
parentbb035ef0cc91e115faa80187ac8886a7f1914d06
bpf: Check for helper calls in check_subprogs()

The condition src_reg != BPF_PSEUDO_CALL && imm == BPF_FUNC_tail_call
may be satisfied by a kfunc call. This would lead to unnecessarily
setting has_tail_call. Use src_reg == 0 instead.

Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Acked-by: Stanislav Fomichev <sdf@google.com>
Link: https://lore.kernel.org/r/20230220163756.753713-1-iii@linux.ibm.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
kernel/bpf/verifier.c