bpf: fix off-by-one error in adjust_subprog_starts
authorEdward Cree <ecree@solarflare.com>
Fri, 16 Nov 2018 12:00:07 +0000 (12:00 +0000)
committerAlexei Starovoitov <ast@kernel.org>
Sat, 17 Nov 2018 05:10:00 +0000 (21:10 -0800)
commitafd594240806acc138cf696c09f2f4829d55d02f
tree88202cf526afbabd2388e3eec49ade42e36c8457
parentda85d8bfd1512461bcfb64929e8426cf340b3707
bpf: fix off-by-one error in adjust_subprog_starts

When patching in a new sequence for the first insn of a subprog, the start
 of that subprog does not change (it's the first insn of the sequence), so
 adjust_subprog_starts should check start <= off (rather than < off).
Also added a test to test_verifier.c (it's essentially the syz reproducer).

Fixes: cc8b0b92a169 ("bpf: introduce function calls (function boundaries)")
Reported-by: syzbot+4fc427c7af994b0948be@syzkaller.appspotmail.com
Signed-off-by: Edward Cree <ecree@solarflare.com>
Acked-by: Yonghong Song <yhs@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
kernel/bpf/verifier.c
tools/testing/selftests/bpf/test_verifier.c