ipc/shm: fix up for struct file no longer being available in shm.h
authorStephen Rothwell <sfr@canb.auug.org.au>
Wed, 28 Mar 2018 07:41:25 +0000 (18:41 +1100)
committerEric W. Biederman <ebiederm@xmission.com>
Wed, 28 Mar 2018 18:29:57 +0000 (13:29 -0500)
commit8ecd2953d0a1b78748b36f5bed6f233f5bd6d6ea
tree730f647c662bb0845f3318669c00dc9f3dba913b
parent0d79cbf83be07bb38a1224f47fd0e2b163310442
ipc/shm: fix up for struct file no longer being available in shm.h

Stephen Rothewell <sfr@canb.auug.org.au> wrote:

> After merging the userns tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> In file included from include/linux/sched.h:16:0,
>                  from arch/powerpc/lib/xor_vmx_glue.c:14:
> include/linux/shm.h:17:35: error: 'struct file' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>  bool is_file_shm_hugepages(struct file *file);
>                                    ^~~~
>
> and many, many more (most warnings, but some errors - arch/powerpc is
> mostly built with -Werror)

I dug through this and I discovered that the error was caused by the
removal of struct shmid_kernel from shm.h when building on powerpc.
Except for observing the existence of "struct file *shm_file" in
struct shmid_kernel I have no clue why the structure move would cause
such a failure.  I suspect shm.h always needed the forward declaration
and someting had been confusing gcc into not issuing the warning. --EWB

Fixes: a2e102cd3cdd ("shm: Move struct shmid_kernel into ipc/shm.c")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
include/linux/shm.h