[XFS] fix NULL pointer dereference in xfs_log_force_umount
authorChristoph Hellwig <hch@infradead.org>
Fri, 28 Nov 2008 03:23:31 +0000 (14:23 +1100)
committerNiv Sardi <xaiki@sgi.com>
Mon, 1 Dec 2008 00:06:44 +0000 (11:06 +1100)
commitbac8dca9f9b1dfcf9c4ecb4f9ca17185b828cc20
treefa26840c5e85eeed63575615c140f2913e6d9189
parentb5a20aa2657063cbf3b47fc700603180de4bb554
[XFS] fix NULL pointer dereference in xfs_log_force_umount

xfs_log_force_umount may be called very early during log recovery where

If we fail a buffer read in xlog_recover_do_inode_trans we abort the mount.
But at that point log recovery has started delayed writeback of inode
buffers.   As part of the aborted mount we try to flush out all delwri
buffers, but at that point we have already freed the superblock, and set
mp->m_sb_bp to NULL, and xfs_log_force_umount which gets called after
the inode buffer writeback trips over it.

Make xfs_log_force_umount a little more careful when accessing mp->m_sb_bp
to avoid this.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
Signed-off-by: Niv Sardi <xaiki@sgi.com>
fs/xfs/xfs_log.c