xfs: prevent a WARN_ONCE() in xfs_ioc_attr_list()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 21 Dec 2021 17:38:19 +0000 (09:38 -0800)
committerDarrick J. Wong <djwong@kernel.org>
Tue, 21 Dec 2021 17:49:41 +0000 (09:49 -0800)
commit6ed6356b07714e0198be3bc3ecccc8b40a212de4
tree1559112e1cb550e684fdd9d18f8329728c19d3e4
parent132c460e49649685bf4b02ba43dea59062f797d9
xfs: prevent a WARN_ONCE() in xfs_ioc_attr_list()

The "bufsize" comes from the root user.  If "bufsize" is negative then,
because of type promotion, neither of the validation checks at the start
of the function are able to catch it:

if (bufsize < sizeof(struct xfs_attrlist) ||
    bufsize > XFS_XATTR_LIST_MAX)
return -EINVAL;

This means "bufsize" will trigger (WARN_ON_ONCE(size > INT_MAX)) in
kvmalloc_node().  Fix this by changing the type from int to size_t.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
fs/xfs/xfs_ioctl.c
fs/xfs/xfs_ioctl.h