xfs: xfs_iflush_cluster fails to abort on error
authorDave Chinner <dchinner@redhat.com>
Wed, 18 May 2016 03:53:42 +0000 (13:53 +1000)
committerDave Chinner <david@fromorbit.com>
Wed, 18 May 2016 03:53:42 +0000 (13:53 +1000)
commitb1438f477934f5a4d5a44df26f3079a7575d5946
tree5eab8bfb381b7a9b20b95a099ebb9fbde917a65e
parent8179c03629de67f515d3ab825b5a9428687d4b85
xfs: xfs_iflush_cluster fails to abort on error

When a failure due to an inode buffer occurs, the error handling
fails to abort the inode writeback correctly. This can result in the
inode being reclaimed whilst still in the AIL, leading to
use-after-free situations as well as filesystems that cannot be
unmounted as the inode log items left in the AIL never get removed.

Fix this by ensuring fatal errors from xfs_imap_to_bp() result in
the inode flush being aborted correctly.

cc: <stable@vger.kernel.org> # 3.10.x-
Reported-by: Shyam Kaushik <shyam@zadarastorage.com>
Diagnosed-by: Shyam Kaushik <shyam@zadarastorage.com>
Tested-by: Shyam Kaushik <shyam@zadarastorage.com>
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/xfs/xfs_inode.c