vfs: Replace all non-returning strlcpy with strscpy
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Wed, 10 May 2023 22:11:19 +0000 (22:11 +0000)
committerChristian Brauner <brauner@kernel.org>
Mon, 15 May 2023 07:42:01 +0000 (09:42 +0200)
commitc642256b91770e201519d037a91f255a617a4602
treef50cc7a3eddae54218cc59291630f32c755bbb1d
parent38f1755a3e59a3f88e33030f8e4ee0421de2f05a
vfs: Replace all non-returning strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Message-Id: <20230510221119.3508930-1-azeemshaikh38@gmail.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/char_dev.c
fs/super.c