proc: proc_pid_ns takes super_block as an argument
authorAlexey Gladkov <gladkov.alexey@gmail.com>
Mon, 18 May 2020 18:07:38 +0000 (20:07 +0200)
committerEric W. Biederman <ebiederm@xmission.com>
Tue, 19 May 2020 12:07:50 +0000 (07:07 -0500)
commit9d78edeaec759f997c303f286ecd39daee166f2a
tree2325279bb24196709e59a506cbf4f346c1e69a2b
parent2dd8083f6d8acd1371ccabedef1c9f1ad272a90d
proc: proc_pid_ns takes super_block as an argument

syzbot found that

  touch /proc/testfile

causes NULL pointer dereference at tomoyo_get_local_path()
because inode of the dentry is NULL.

Before c59f415a7cb6, Tomoyo received pid_ns from proc's s_fs_info
directly. Since proc_pid_ns() can only work with inode, using it in
the tomoyo_get_local_path() was wrong.

To avoid creating more functions for getting proc_ns, change the
argument type of the proc_pid_ns() function. Then, Tomoyo can use
the existing super_block to get pid_ns.

Link: https://lkml.kernel.org/r/0000000000002f0c7505a5b0e04c@google.com
Link: https://lkml.kernel.org/r/20200518180738.2939611-1-gladkov.alexey@gmail.com
Reported-by: syzbot+c1af344512918c61362c@syzkaller.appspotmail.com
Fixes: c59f415a7cb6 ("Use proc_pid_ns() to get pid_namespace from the proc superblock")
Signed-off-by: Alexey Gladkov <gladkov.alexey@gmail.com>
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
fs/locks.c
fs/proc/array.c
fs/proc/base.c
fs/proc/self.c
fs/proc/thread_self.c
include/linux/proc_fs.h
kernel/fork.c
net/ipv6/ip6_flowlabel.c
security/tomoyo/realpath.c