io_uring: synchronise ev_posted() with waitqueues
authorPavel Begunkov <asml.silence@gmail.com>
Thu, 7 Jan 2021 03:15:43 +0000 (03:15 +0000)
committerJens Axboe <axboe@kernel.dk>
Thu, 7 Jan 2021 14:48:09 +0000 (07:48 -0700)
commitb1445e59cc9a10fdb8f83810ae1f4feb941ab36b
tree3f7ec8dc6d43cbc0baf2b2d33824ba266e0aea0d
parent4aa84f2ffa81f71e15e5cffc2cc6090dbee78f8e
io_uring: synchronise ev_posted() with waitqueues

waitqueue_active() needs smp_mb() to be in sync with waitqueues
modification, but we miss it in io_cqring_ev_posted*() apart from
cq_wait() case.

Take an smb_mb() out of wq_has_sleeper() making it waitqueue_active(),
and place it a few lines before, so it can synchronise other
waitqueue_active() as well.

The patch doesn't add any additional overhead, so even if there are
no problems currently, it's just safer to have it this way.

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c