file: Factor files_lookup_fd_locked out of fcheck_files
authorEric W. Biederman <ebiederm@xmission.com>
Fri, 20 Nov 2020 23:14:25 +0000 (17:14 -0600)
committerEric W. Biederman <ebiederm@xmission.com>
Thu, 10 Dec 2020 18:39:59 +0000 (12:39 -0600)
commit120ce2b0cd52abe73e8b16c23461eb14df5a87d8
tree8df6b2fe4cf87d23b757ec605c133a47a3742fc2
parentbebf684bf330915e6c96313ad7db89a5480fc9c2
file: Factor files_lookup_fd_locked out of fcheck_files

To make it easy to tell where files->file_lock protection is being
used when looking up a file create files_lookup_fd_locked.  Only allow
this function to be called with the file_lock held.

Update the callers of fcheck and fcheck_files that are called with the
files->file_lock held to call files_lookup_fd_locked instead.

Hopefully this makes it easier to quickly understand what is going on.

The need for better names became apparent in the last round of
discussion of this set of changes[1].

[1] https://lkml.kernel.org/r/CAHk-=wj8BQbgJFLa+J0e=iT-1qpmCRTbPAJ8gd6MJQ=kbRPqyQ@mail.gmail.com
Link: https://lkml.kernel.org/r/20201120231441.29911-8-ebiederm@xmission.com
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
fs/file.c
fs/locks.c
fs/proc/fd.c
include/linux/fdtable.h