ext4: fix i_blocks/quota accounting when extent insertion fails
authorMaxim Patlasov <maxim.patlasov@gmail.com>
Sun, 10 Jul 2011 23:37:48 +0000 (19:37 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Sun, 10 Jul 2011 23:37:48 +0000 (19:37 -0400)
commit7132de744ba76930d13033061018ddd7e3e8cd91
tree1da773f7293e056e4849dc590dac35854662f666
parent275d3ba6b40d0f098693b9089c6fee9bd4e55d74
ext4: fix i_blocks/quota accounting when extent insertion fails

The current implementation of ext4_free_blocks() always calls
dquot_free_block This looks quite sensible in the most cases: blocks
to be freed are associated with inode and were accounted in quota and
i_blocks some time ago.

However, there is a case when blocks to free were not accounted by the
time calling ext4_free_blocks() yet:

1. delalloc is on, write_begin pre-allocated some space in quota
2. write-back happens, ext4 allocates some blocks in ext4_ext_map_blocks()
3. then ext4_ext_map_blocks() gets an error (e.g.  ENOSPC) from
   ext4_ext_insert_extent() and calls ext4_free_blocks().

In this scenario, ext4_free_blocks() calls dquot_free_block() who, in
turn, decrements i_blocks for blocks which were not accounted yet (due
to delalloc) After clean umount, e2fsck reports something like:

> Inode 21, i_blocks is 5080, should be 5128.  Fix<y>?
because i_blocks was erroneously decremented as explained above.

The patch fixes the problem by passing the new flag
EXT4_FREE_BLOCKS_NO_QUOT_UPDATE to ext4_free_blocks(), to request
that the dquot_free_block() call be skipped.

Signed-off-by: Maxim Patlasov <maxim.patlasov@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@kernel.org
fs/ext4/ext4.h
fs/ext4/extents.c
fs/ext4/mballoc.c