configfs: fix a race in configfs_{,un}register_subsystem()
authorChenXiaoSong <chenxiaosong2@huawei.com>
Tue, 15 Feb 2022 07:10:30 +0000 (15:10 +0800)
committerChristoph Hellwig <hch@lst.de>
Tue, 22 Feb 2022 17:30:28 +0000 (18:30 +0100)
commit84ec758fb2daa236026506868c8796b0500c047d
treece8ffacc756674199e92e4c9b07a200e715fb801
parent038101e6b2cd5c55f888f85db42ea2ad3aecb4b6
configfs: fix a race in configfs_{,un}register_subsystem()

When configfs_register_subsystem() or configfs_unregister_subsystem()
is executing link_group() or unlink_group(),
it is possible that two processes add or delete list concurrently.
Some unfortunate interleavings of them can cause kernel panic.

One of cases is:
A --> B --> C --> D
A <-- B <-- C <-- D

     delete list_head *B        |      delete list_head *C
--------------------------------|-----------------------------------
configfs_unregister_subsystem   |   configfs_unregister_subsystem
  unlink_group                  |     unlink_group
    unlink_obj                  |       unlink_obj
      list_del_init             |         list_del_init
        __list_del_entry        |           __list_del_entry
          __list_del            |             __list_del
            // next == C        |
            next->prev = prev   |
                                |               next->prev = prev
            prev->next = next   |
                                |                 // prev == B
                                |                 prev->next = next

Fix this by adding mutex when calling link_group() or unlink_group(),
but parent configfs_subsystem is NULL when config_item is root.
So I create a mutex configfs_subsystem_mutex.

Fixes: 7063fbf22611 ("[PATCH] configfs: User-driven configuration filesystem")
Signed-off-by: ChenXiaoSong <chenxiaosong2@huawei.com>
Signed-off-by: Laibin Qiu <qiulaibin@huawei.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
fs/configfs/dir.c