btrfs: fix direct I/O read repair for split bios
authorChristoph Hellwig <hch@lst.de>
Thu, 24 Mar 2022 16:06:27 +0000 (17:06 +0100)
committerDavid Sterba <dsterba@suse.com>
Tue, 19 Apr 2022 13:44:56 +0000 (15:44 +0200)
commit00d825258bcc09c0e1b99aa7f9ad7d2c2fad41fa
treed0d5be36a3ed71c13c1c76ceca6b2fbfd1777e9a
parent50f1cff3d8865909727fad6f960ce5a050799d00
btrfs: fix direct I/O read repair for split bios

When a bio is split in btrfs_submit_direct, dip->file_offset contains
the file offset for the first bio.  But this means the start value used
in btrfs_check_read_dio_bio is incorrect for subsequent bios.  Add
a file_offset field to struct btrfs_bio to pass along the correct offset.

Given that check_data_csum only uses start of an error message this
means problems with this miscalculation will only show up when I/O fails
or checksums mismatch.

The logic was removed in f4f39fc5dc30 ("btrfs: remove btrfs_bio::logical
member") but we need it due to the bio splitting.

CC: stable@vger.kernel.org # 5.16+
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Naohiro Aota <naohiro.aota@wdc.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: Sweet Tea Dorminy <sweettea-kernel@dorminy.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/extent_io.c
fs/btrfs/inode.c
fs/btrfs/volumes.h