btrfs: create free space tree on ro->rw remount
authorBoris Burkov <boris@bur.io>
Wed, 18 Nov 2020 23:06:19 +0000 (15:06 -0800)
committerDavid Sterba <dsterba@suse.com>
Wed, 9 Dec 2020 18:16:07 +0000 (19:16 +0100)
commit5011139a4718455a6cd6214fd84e6f8500fd3874
tree5a598fb85f938c0c3b85eaddfcf4beef84f7cd73
parent997e3e2e71b32b31bfab6b299d9db05af285b457
btrfs: create free space tree on ro->rw remount

When a user attempts to remount a btrfs filesystem with
'mount -o remount,space_cache=v2', that operation silently succeeds.
Unfortunately, this is misleading, because the remount does not create
the free space tree. /proc/mounts will incorrectly show space_cache=v2,
but on the next mount, the file system will revert to the old
space_cache.

For now, we handle only the easier case, where the existing mount is
read-only and the new mount is read-write. In that case, we can create
the free space tree without contending with the block groups changing
as we go.

Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Boris Burkov <boris@bur.io>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/disk-io.c