xen/pvcalls: fix unsigned less than zero error check
authorColin Ian King <colin.king@canonical.com>
Fri, 3 Nov 2017 08:42:02 +0000 (08:42 +0000)
committerBoris Ostrovsky <boris.ostrovsky@oracle.com>
Fri, 3 Nov 2017 15:38:27 +0000 (11:38 -0400)
commit95110ac88d5139c73eef6ede37eff23c4089f4f2
treece0fa7aa52ff330e56e6be4d10e2ab38c8ac0e90
parentb5494ad83fb52a8e5a7dc1d30cb42cbca5d617f1
xen/pvcalls: fix unsigned less than zero error check

The check on bedata->ref is never true because ref is an unsigned
integer. Fix this by assigning signed int ret to the return of the
call to gnttab_claim_grant_reference so the -ve return can be checked.

Detected by CoverityScan, CID#1460358 ("Unsigned compared against 0")

Fixes: 219681909913 ("xen/pvcalls: connect to the backend")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
drivers/xen/pvcalls-front.c