vhost/vsock: Fix error handling in vhost_vsock_init()
authorYuan Can <yuancan@huawei.com>
Tue, 8 Nov 2022 10:17:05 +0000 (10:17 +0000)
committerMichael S. Tsirkin <mst@redhat.com>
Wed, 28 Dec 2022 10:28:10 +0000 (05:28 -0500)
commit7a4efe182ca61fb3e5307e69b261c57cbf434cd4
tree3a139679f86815dbd8c4a1bae4b7a8b897fe4d97
parentaeca7ff254843d49a8739f07f7dab1341450111d
vhost/vsock: Fix error handling in vhost_vsock_init()

A problem about modprobe vhost_vsock failed is triggered with the
following log given:

modprobe: ERROR: could not insert 'vhost_vsock': Device or resource busy

The reason is that vhost_vsock_init() returns misc_register() directly
without checking its return value, if misc_register() failed, it returns
without calling vsock_core_unregister() on vhost_transport, resulting the
vhost_vsock can never be installed later.
A simple call graph is shown as below:

 vhost_vsock_init()
   vsock_core_register() # register vhost_transport
   misc_register()
     device_create_with_groups()
       device_create_groups_vargs()
         dev = kzalloc(...) # OOM happened
   # return without unregister vhost_transport

Fix by calling vsock_core_unregister() when misc_register() returns error.

Fixes: 433fc58e6bf2 ("VSOCK: Introduce vhost_vsock.ko")
Signed-off-by: Yuan Can <yuancan@huawei.com>
Message-Id: <20221108101705.45981-1-yuancan@huawei.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
drivers/vhost/vsock.c