scsi: sd: Contribute to randomness when running rotational device
authorXuewei Zhang <xueweiz@google.com>
Thu, 6 Sep 2018 20:37:19 +0000 (13:37 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 17 Sep 2018 06:57:10 +0000 (02:57 -0400)
commit83e32a5910772e1475d3640a429b7686695f04d1
treebded4bee164404584632e082179544f243791a8f
parentadad633af7b970bfa5dd1b624a4afc83cac9b235
scsi: sd: Contribute to randomness when running rotational device

Currently a scsi device won't contribute to kernel randomness when it uses
blk-mq. Since we commonly use scsi on rotational device with blk-mq, it make
sense to keep contributing to kernel randomness in these cases. This is
especially important for virtual machines.

commit b5b6e8c8d3b4 ("scsi: virtio_scsi: fix IO hang caused by automatic irq
vector affinity") made all virtio-scsi device to use blk-mq, which does not
contribute to randomness today. So for a virtual machine only having
virtio-scsi disk (which is common), it will simple stop getting randomness
from its disks in today's implementation.

With this patch, if the above VM has rotational virtio-scsi device, then it
can still benefit from the entropy generated from the disk.

Reported-by: Xuewei Zhang <xueweiz@google.com>
Signed-off-by: Xuewei Zhang <xueweiz@google.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Maciej Żenczykowski <maze@google.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/sd.c