scsi: lpfc: Fix possible file string name overflow when updating firmware
authorJustin Tee <justin.tee@broadcom.com>
Tue, 31 Oct 2023 19:12:17 +0000 (12:12 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 15 Nov 2023 14:52:57 +0000 (09:52 -0500)
commitf5779b529240b715f0e358489ad0ed933bf77c97
treeb4bb842c071a070646bbf2cb7cce1fe4f8fcb8e8
parent2fe4b6a67730e6ffd002b2b3c4752ef262fedde4
scsi: lpfc: Fix possible file string name overflow when updating firmware

Because file_name and phba->ModelName are both declared a size 80 bytes,
the extra ".grp" file extension could cause an overflow into file_name.

Define a ELX_FW_NAME_SIZE macro with value 84.  84 incorporates the 4 extra
characters from ".grp".  file_name is changed to be declared as a char and
initialized to zeros i.e. null chars.

Signed-off-by: Justin Tee <justin.tee@broadcom.com>
Link: https://lore.kernel.org/r/20231031191224.150862-3-justintee8345@gmail.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc.h
drivers/scsi/lpfc/lpfc_init.c