OPP: Simplify the over-designed pstate <-> level dance
authorViresh Kumar <viresh.kumar@linaro.org>
Wed, 14 Jun 2023 09:59:32 +0000 (15:29 +0530)
committerViresh Kumar <viresh.kumar@linaro.org>
Mon, 19 Jun 2023 04:20:09 +0000 (09:50 +0530)
commit7c41cdcd3bbee5d49de9d4821b15e49d155ff22b
tree90c682ac35d71e68606a2fbee21a385881e24b20
parent84cb7ff35fcf7c0b552f553a3f2db9c3e92fc707
OPP: Simplify the over-designed pstate <-> level dance

While adding support for "performance states" in the OPP and genpd core,
it was decided to set the `pstate` field via genpd's
pm_genpd_opp_to_performance_state() helper, to allow platforms to set
`pstate` even if they don't have a corresponding `level` field in the DT
OPP tables (More details are present in commit 6e41766a6a50 ("PM /
Domain: Implement of_genpd_opp_to_performance_state()")).

Revisiting that five years later clearly suggests that it was
over-designed as all current users are eventually using the `level`
value only.

The previous commit already added necessary checks to make sure pstate
is only used for genpd tables. Lets now simplify this a little, and use
`level` directly and remove `pstate` field altogether.

Suggested-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/opp/core.c
drivers/opp/debugfs.c
drivers/opp/of.c
drivers/opp/opp.h