nfp: remove the refresh of all ports optimization
authorJakub Kicinski <jakub.kicinski@netronome.com>
Sun, 23 Apr 2017 03:17:56 +0000 (20:17 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 24 Apr 2017 18:35:44 +0000 (14:35 -0400)
commit90fdc561b08ce292f1d39a62f70012f150583b98
treee91b5255668df358acb2eda390f902ecd99fce60
parentee200a7377fb6ce5ea6d631af0905883f0dca6d2
nfp: remove the refresh of all ports optimization

The code refreshing the eth port state was trying to update state
of all ports of the card.  Unfortunately to safely walk the port
list we would have to hold the port lock, which we can't due to
lock ordering constraints against rtnl.

Make the per-port sync refresh and async refresh of all ports
completely separate routines.

Fixes: 172f638c93dd ("nfp: add port state refresh")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/netronome/nfp/nfp_net.h
drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
drivers/net/ethernet/netronome/nfp/nfp_net_main.c