media: si2165: fix a missing check of return value
authorKangjie Lu <kjlu@umn.edu>
Fri, 21 Dec 2018 04:54:03 +0000 (23:54 -0500)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Tue, 19 Mar 2019 20:47:20 +0000 (16:47 -0400)
commit0ab34a08812a3334350dbaf69a018ee0ab3d2ddd
treebc758e0bb675e0a991ed0ffcaea6e589d607000b
parent56cd26b618855c9af48c8301aa6754ced8dd0beb
media: si2165: fix a missing check of return value

si2165_readreg8() may fail. Looking into si2165_readreg8(), we will find
that "val_tmp" will be an uninitialized value when regmap_read() fails.
"val_tmp" is then assigned to "val". So if si2165_readreg8() fails,
"val" will be a random value. Further use will lead to undefined
behaviors. The fix checks if si2165_readreg8() fails, and if so, returns
its error code upstream.

Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Reviewed-by: Matthias Schwarzott <zzam@gentoo.org>
Tested-by: Matthias Schwarzott <zzam@gentoo.org>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/dvb-frontends/si2165.c