md: remove special meaning of ->quiesce(.., 2)
authorNeilBrown <neilb@suse.com>
Thu, 19 Oct 2017 01:49:15 +0000 (12:49 +1100)
committerShaohua Li <shli@fb.com>
Thu, 2 Nov 2017 04:32:20 +0000 (21:32 -0700)
commitb03e0ccb5ab9df3efbe51c87843a1ffbecbafa1f
tree4991194aa067e459500bf1c6515b6d716145165c
parent35bfc52187f6df8779d0f1cebdb52b7f797baf4e
md: remove special meaning of ->quiesce(.., 2)

The '2' argument means "wake up anything that is waiting".
This is an inelegant part of the design and was added
to help support management of suspend_lo/suspend_hi setting.
Now that suspend_lo/hi is managed in mddev_suspend/resume,
that need is gone.
These is still a couple of places where we call 'quiesce'
with an argument of '2', but they can safely be changed to
call ->quiesce(.., 1); ->quiesce(.., 0) which
achieve the same result at the small cost of pausing IO
briefly.

This removes a small "optimization" from suspend_{hi,lo}_store,
but it isn't clear that optimization served a useful purpose.
The code now is a lot clearer.

Suggested-by: Shaohua Li <shli@kernel.org>
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Shaohua Li <shli@fb.com>
drivers/md/md-cluster.c
drivers/md/md.c
drivers/md/md.h
drivers/md/raid0.c
drivers/md/raid1.c
drivers/md/raid10.c
drivers/md/raid5-cache.c
drivers/md/raid5-log.h
drivers/md/raid5.c