bcache: avoid potential memleak of list of journal_replay(s) in the CACHE_SYNC branch...
authorShenghui Wang <shhuiw@foxmail.com>
Wed, 24 Apr 2019 16:48:43 +0000 (00:48 +0800)
committerJens Axboe <axboe@kernel.dk>
Wed, 24 Apr 2019 16:56:29 +0000 (10:56 -0600)
commit95f18c9d1310730d075499a75aaf13bcd60405a7
treeed68f08953dc63694dc0e60ab0bbbe5bfe0bf412
parentf16277ca20acf2c213fcd4b645f4c1cffcadf533
bcache: avoid potential memleak of list of journal_replay(s) in the CACHE_SYNC branch of run_cache_set

In the CACHE_SYNC branch of run_cache_set(), LIST_HEAD(journal) is used
to collect journal_replay(s) and filled by bch_journal_read().

If all goes well, bch_journal_replay() will release the list of
jounal_replay(s) at the end of the branch.

If something goes wrong, code flow will jump to the label "err:" and leave
the list unreleased.

This patch will release the list of journal_replay(s) in the case of
error detected.

v1 -> v2:
* Move the release code to the location after label 'err:' to
  simply the change.

Signed-off-by: Shenghui Wang <shhuiw@foxmail.com>
Signed-off-by: Coly Li <colyli@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/md/bcache/super.c