leds: class: Improve LED and LED flash class registration API
authorJacek Anaszewski <jacek.anaszewski@gmail.com>
Sun, 9 Jun 2019 18:19:03 +0000 (20:19 +0200)
committerJacek Anaszewski <jacek.anaszewski@gmail.com>
Thu, 25 Jul 2019 18:07:50 +0000 (20:07 +0200)
commitb2b998c0f944993c9ef435569651e407d607af41
tree28d4f69784e203114b5feb8b5bde12510e9c42ee
parent7d9d60bdfa45181e439b50bb067e97168b99f89e
leds: class: Improve LED and LED flash class registration API

Replace of_led_classdev_register() with led_classdev_register_ext(), which
accepts easily extendable struct led_init_data, instead of the fixed
struct device_node argument. The latter can be now passed in an fwnode
property of the struct led_init_data.

The modification is driven by the need for passing additional arguments
required for the forthcoming generic mechanism for composing LED names.
Currently the LED name is conveyed in the "name" char pointer property of
the struct led_classdev. This is redundant since LED class device name
is accessible throughout the whole LED class device life time via
associated struct device's kobj->name property.

The change will not break any existing clients since the patch alters
also existing led_classdev{_flash}_register() macro wrappers, that pass
NULL in place of init_data, which leads to using legacy name
initialization path basing on the struct led_classdev's "name" property.

Three existing users of devm_of_led_classdev_registers() are modified
to use devm_led_classdev_register(), which will not impact their
operation since they in fact didn't need to pass struct device_node on
registration from the beginning.

Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Baolin Wang <baolin.wang@linaro.org>
Cc: Dan Murphy <dmurphy@ti.com>
Cc: Daniel Mack <daniel@zonque.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Oleh Kravchenko <oleg@kaa.org.ua>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Simon Shields <simon@lineageos.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
drivers/leds/led-class-flash.c
drivers/leds/led-class.c
drivers/leds/leds-cr0014114.c
drivers/leds/leds-gpio.c
drivers/leds/leds-max77650.c
drivers/leds/leds-pwm.c
include/linux/led-class-flash.h
include/linux/leds.h