drm/i915/icl: Add TypeC ports only if VBT is present
authorImre Deak <imre.deak@intel.com>
Mon, 28 Jan 2019 11:42:42 +0000 (13:42 +0200)
committerImre Deak <imre.deak@intel.com>
Thu, 31 Jan 2019 14:28:33 +0000 (16:28 +0200)
commit828ccb31cf410a1a01e2bdc2a3cf0dd5aabb755d
treed30c9d6129fc5954aff5832ec2aebeb4e01982fe
parent8aae2b1cdf4452817943741ed792068b18191465
drm/i915/icl: Add TypeC ports only if VBT is present

We can't safely probe Type C ports, whether they are a legacy or a
USB/Thunderbolt DP Alternate Type C port. This would require performing
the TypeC connect sequence - as described by the specification - but
that may have unwanted side-effects. These side-effects include at least
- without completeness - timeouts during AUX power well enabling and
subsequent PLL enabling errors.

To safely identify these ports we really need VBT, which has the proper
flag for this (ddi_vbt_port_info::supports_typec_usb, supports_tbt).
Based on the above disable Type C ports if we can't load VBT for some
reason.

v2:
- Notice that we disable TypeC ports completely and simplify accordingly
  (Jose).
- Add code comment explaining why we disabled the ports. (Jani)

Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: Jose Roberto de Souza <jose.souza@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190128114242.28666-1-imre.deak@intel.com
drivers/gpu/drm/i915/intel_bios.c