cpufreq: pcc: Fix the potentinal scheduling delays in target_index()
authorLiao Chang <liaochang1@huawei.com>
Sat, 26 Aug 2023 09:57:43 +0000 (09:57 +0000)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 29 Aug 2023 18:41:29 +0000 (20:41 +0200)
commit4c2fdf7393647a7b01a83f49c4a331d562016640
treecedfea0660e686d0049467d67d8f4fb5ec9e01ae
parent916f13884042f615cfbfc0b42cc68dadee826f2a
cpufreq: pcc: Fix the potentinal scheduling delays in target_index()

pcc_cpufreq_target():
cpufreq_freq_transition_begin();
spin_lock(&pcc_lock);
[critical section]
cpufreq_freq_transition_end();
spin_unlock(&pcc_lock);

Above code has a performance issue, consider that Task0 executes
'cpufreq_freq_transition_end()' to wake Task1 and preempted imediatedly
without releasing 'pcc_lock', then Task1 needs to wait for Task0 to
release 'pcc_lock'. In the worst case, this locking order can result in
Task1 wasting two scheduling rounds before it can enter the critical
section.

Signed-off-by: Liao Chang <liaochang1@huawei.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/pcc-cpufreq.c