crypto: scatterwalk - use kmap_local() not kmap_atomic()
authorArd Biesheuvel <ardb@kernel.org>
Tue, 13 Dec 2022 16:13:10 +0000 (17:13 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 30 Dec 2022 14:56:27 +0000 (22:56 +0800)
commitaa9695157f65c55e5c85a1c194859d3c03e68018
tree92cab03ac269b23b3211b3d5ae41317c389fa536
parentb517b0fbfec836391427649b207735afb698fcf3
crypto: scatterwalk - use kmap_local() not kmap_atomic()

kmap_atomic() is used to create short-lived mappings of pages that may
not be accessible via the kernel direct map. This is only needed on
32-bit architectures that implement CONFIG_HIGHMEM, but it can be used
on 64-bit other architectures too, where the returned mapping is simply
the kernel direct address of the page.

However, kmap_atomic() does not support migration on CONFIG_HIGHMEM
configurations, due to the use of per-CPU kmap slots, and so it disables
preemption on all architectures, not just the 32-bit ones. This implies
that all scatterwalk based crypto routines essentially execute with
preemption disabled all the time, which is less than ideal.

So let's switch scatterwalk_map/_unmap and the shash/ahash routines to
kmap_local() instead, which serves a similar purpose, but without the
resulting impact on preemption on architectures that have no need for
CONFIG_HIGHMEM.

Cc: Eric Biggers <ebiggers@kernel.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "Elliott, Robert (Servers)" <elliott@hpe.com>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/ahash.c
crypto/shash.c
include/crypto/scatterwalk.h