crypto: ecdh - fix big endian bug in ECC library
authorArd Biesheuvel <ard.biesheuvel@linaro.org>
Wed, 23 Oct 2019 09:50:44 +0000 (11:50 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 1 Nov 2019 05:38:31 +0000 (13:38 +0800)
commitf398243e9fd6a3a059c1ea7b380c40628dbf0c61
tree7fbad1852deba37b65ae8453f7566828d3affbce
parent51d13aaf59779ff4d13f1def2c72ae102a1aad40
crypto: ecdh - fix big endian bug in ECC library

The elliptic curve arithmetic library used by the EC-DH KPP implementation
assumes big endian byte order, and unconditionally reverses the byte
and word order of multi-limb quantities. On big endian systems, the byte
reordering is not necessary, while the word ordering needs to be retained.

So replace the __swab64() invocation with a call to be64_to_cpu() which
should do the right thing for both little and big endian builds.

Fixes: 3c4b23901a0c ("crypto: ecdh - Add ECDH software support")
Cc: <stable@vger.kernel.org> # v4.9+
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/ecc.c