block: Hold invalidate_lock in BLKDISCARD ioctl
authorShin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Tue, 9 Nov 2021 10:47:22 +0000 (19:47 +0900)
committerJens Axboe <axboe@kernel.dk>
Tue, 9 Nov 2021 19:41:12 +0000 (12:41 -0700)
commit7607c44c157d343223510c8ffdf7206fdd2a6213
tree5d583e2d24b462f62bad819bd52c45f50d6d16d9
parentcb690f5238d71f543f4ce874aa59237cf53a877c
block: Hold invalidate_lock in BLKDISCARD ioctl

When BLKDISCARD ioctl and data read race, the data read leaves stale
page cache. To avoid the stale page cache, hold invalidate_lock of the
block device file mapping. The stale page cache is observed when
blktests test case block/009 is repeated hundreds of times.

This patch can be applied back to the stable kernel version v5.15.y
with slight patch edit. Rework is required for older stable kernels.

Fixes: 351499a172c0 ("block: Invalidate cache on discard v2")
Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: stable@vger.kernel.org # v5.15
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20211109104723.835533-2-shinichiro.kawasaki@wdc.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/ioctl.c