blk-iocost: move wbt_enable/disable_default() out of spinlock
authorYu Kuai <yukuai3@huawei.com>
Sat, 27 May 2023 01:06:43 +0000 (09:06 +0800)
committerJens Axboe <axboe@kernel.dk>
Mon, 26 Jun 2023 15:53:36 +0000 (09:53 -0600)
commiteebc21d12f56c1e09a163abf91e351fa2a55a938
tree31b8644fe6536bd0d886911844505c91abf68bb4
parent06257fda83ebfd1c33fb992e41dba7be4e1184d4
blk-iocost: move wbt_enable/disable_default() out of spinlock

There are following smatch warning:

block/blk-wbt.c:843 wbt_init() warn: sleeping in atomic context
ioc_qos_write() <- disables preempt
-> wbt_enable_default()
   -> wbt_init()

wbt_init() will be called from wbt_enable_default() if wbt is not
initialized, currently this is only possible in blk_register_queue(), hence
wbt_init() will never be called from iocost and this warning is false
positive.

However, we might support rq_qos destruction dynamically in the future,
and it's better to prevent that, hence move wbt_enable_default() outside
'ioc->lock'. This is safe because queue is still freezed.

Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://lore.kernel.org/lkml/Y+Ja5SRs886CEz7a@kadam/
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20230527010644.647900-5-yukuai1@huaweicloud.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-iocost.c