block, bfq: switch 'bfqg->ref' to use atomic refcount apis
authorYu Kuai <yukuai3@huawei.com>
Tue, 3 Jan 2023 08:47:55 +0000 (16:47 +0800)
committerJens Axboe <axboe@kernel.dk>
Mon, 16 Jan 2023 03:53:27 +0000 (20:53 -0700)
commit216f764716f34fe68cedc7296ae2043a7727e640
tree2e5261483bfdff8833f016b56ea997a1b48294d7
parentee16c404f9bd03c6e083f76d45be0b6a774c0d14
block, bfq: switch 'bfqg->ref' to use atomic refcount apis

The updating of 'bfqg->ref' should be protected by 'bfqd->lock', however,
during code review, we found that bfq_pd_free() update 'bfqg->ref'
without holding the lock, which is problematic:

1) bfq_pd_free() triggered by removing cgroup is called asynchronously;
2) bfqq will grab bfqg reference, and exit bfqq will drop the reference,
which can concurrent with 1).

Unfortunately, 'bfqd->lock' can't be held here because 'bfqd' might already
be freed in bfq_pd_free(). Fix the problem by using atomic refcount apis.

Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230103084755.1256479-1-yukuai1@huaweicloud.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/bfq-cgroup.c
block/bfq-iosched.h