X-Git-Url: https://git.kernel.dk/?a=blobdiff_plain;f=ioengines.c;h=7f0a5c4520bab954d1e8eaa4df04ee115f8290e1;hb=792d551747e83601121afce033a66f357c9fc439;hp=4c97d038630e05c8767907fbd09db1ac862f21f4;hpb=5f9099ea8adf423d0db01274ef0d7e65629c0e1c;p=fio.git diff --git a/ioengines.c b/ioengines.c index 4c97d038..7f0a5c45 100644 --- a/ioengines.c +++ b/ioengines.c @@ -245,6 +245,18 @@ int td_io_queue(struct thread_data *td, struct io_u *io_u) unlock_file(td, io_u->file); + /* + * Add warning for O_DIRECT so that users have an easier time + * spotting potentially bad alignment. If this triggers for the first + * IO, then it's likely an alignment problem or because the host fs + * does not support O_DIRECT + */ + if (io_u->error == EINVAL && td->io_issues[io_u->ddir] == 1 && + td->o.odirect) { + log_info("fio: first direct IO errored. File system may not " + "support direct IO, or iomem_align= is bad.\n"); + } + if (!td->io_ops->commit) { io_u_mark_submit(td, 1); io_u_mark_complete(td, 1);