X-Git-Url: https://git.kernel.dk/?a=blobdiff_plain;f=exp%2Fexpression-parser.y;h=d664b8edd310d3ab36c8b5880158ded0c5507c32;hb=44cc9c8fccd1862045ef029dc9a484c4a2e46731;hp=f5a7981f2fbfa8eb6bdacc61d5d99c6e81c9e1f5;hpb=ae46966a4a0f0db7eb34a7b82d39a86735a8a293;p=fio.git

diff --git a/exp/expression-parser.y b/exp/expression-parser.y
index f5a7981f..d664b8ed 100644
--- a/exp/expression-parser.y
+++ b/exp/expression-parser.y
@@ -21,6 +21,7 @@
 #include <stdio.h>
 #include <string.h>
 #include <math.h>
+
 struct parser_value_type {
 	double dval;
 	long long ival;
@@ -37,10 +38,12 @@ typedef union valtype {
 int yyerror(__attribute__((unused)) long long *result,
 		__attribute__((unused)) double *dresult,
 		__attribute__((unused)) int *has_error,
-		__attribute__((unused)) int *bye, const char *msg);
+		__attribute__((unused)) int *units_specified,
+		__attribute__((unused)) const char *msg);
 
 extern int yylex(void);
 extern void yyrestart(FILE *file);
+extern int lexer_value_is_time;
 
 %}
 
@@ -57,13 +60,15 @@ extern void yyrestart(FILE *file);
 %token <v> BYE
 %token <v> SUFFIX 
 %left '-' '+'
+%right SUFFIX
 %left '*' '/'
 %right '^'
+%left '%'
 %nonassoc UMINUS
 %parse-param { long long *result }
 %parse-param { double *dresult }
 %parse-param { int *has_error }
-%parse-param { int *bye }
+%parse-param { int *units_specified }
 
 %type <v> expression
 %%
@@ -131,6 +136,18 @@ expression:	expression '+' expression {
 			else
 				$$.dval = $1.ival * $2.ival;
 			$$.has_error = $1.has_error || $2.has_error;
+			*units_specified = 1;
+		}
+	|	expression '%' expression {
+			if ($1.has_dval || $3.has_dval)
+				yyerror(0, 0, 0, 0, "modulo on floats");
+			if ($3.ival == 0)
+				yyerror(0, 0, 0, 0, "divide by zero");
+			else {
+				$$.ival = $1.ival % $3.ival;
+				$$.dval = $$.ival;
+			}
+			$$.has_error = $1.has_error || $3.has_error;
 		}
 	|	expression '^' expression {
 			$$.has_error = $1.has_error || $3.has_error;
@@ -151,8 +168,9 @@ expression:	expression '+' expression {
 						tmp = 1.0;
 						$$.has_error = 1;
 					} else {
-						tmp = pow((double) $1.ival,
-								(double) $3.ival);
+						double x = (double) $1.ival;
+						double y = (double) $3.ival;
+						tmp = pow(x, y);
 					}
 					$$.ival = (long long) tmp;
 				}
@@ -162,8 +180,7 @@ expression:	expression '+' expression {
 				$$.ival = (long long) $$.dval;
 			}
 		}
-	|	NUMBER { $$ = $1; }
-	|	BYE { $$ = $1; *bye = 1; };
+	|	NUMBER { $$ = $1; };
 %%
 #include <stdio.h>
 
@@ -171,7 +188,7 @@ expression:	expression '+' expression {
 static int lexer_read_offset = 0;
 static char lexer_input_buffer[1000];
 
-int lexer_input(char* buffer, int *bytes_read, int bytes_requested)
+int lexer_input(char* buffer, unsigned int *bytes_read, int bytes_requested)
 {
 	int bytes_left = strlen(lexer_input_buffer) - lexer_read_offset;
 
@@ -197,27 +214,34 @@ static void setup_to_parse_string(const char *string)
 	lexer_read_offset = 0;
 }
 
-int evaluate_arithmetic_expression(const char *buffer, long long *ival, double *dval)
+int evaluate_arithmetic_expression(const char *buffer, long long *ival, double *dval,
+					double implied_units, int is_time)
 {
-	int rc, bye = 0, has_error = 0;
+	int rc, units_specified = 0, has_error = 0;
 
+	lexer_value_is_time = is_time;
 	setup_to_parse_string(buffer);
-	rc = yyparse(ival, dval, &has_error, &bye);
+	rc = yyparse(ival, dval, &has_error, &units_specified);
 	yyrestart(NULL);
-	if (rc || bye || has_error) {
+	if (rc || has_error) {
 		*ival = 0;
 		*dval = 0;
 		has_error = 1;
 	}
+	if (!units_specified) {
+		*ival = (int) ((double) *ival * implied_units);
+		*dval = *dval * implied_units;
+	}
 	return has_error;
 }
 
 int yyerror(__attribute__((unused)) long long *result,
 		__attribute__((unused)) double *dresult,
 		__attribute__((unused)) int *has_error,
-		__attribute__((unused)) int *bye, const char *msg)
+		__attribute__((unused)) int *units_specified,
+		__attribute__((unused)) const char *msg)
 {
-	fprintf(stderr, "%s\n", msg);
+	/* We do not need to do anything here. */
 	return 0;
 }