X-Git-Url: https://git.kernel.dk/?a=blobdiff_plain;f=engines%2Fskeleton_external.c;h=548676a782a99bd94519c40444e866214d1fd25b;hb=7670fce49ede1ff1361f177c26cd2d41621ee081;hp=9000accf5e2d639f28f533993fed775519d3d2da;hpb=317b95d07d4921d2594a1be6e014c9c2d062fe75;p=fio.git

diff --git a/engines/skeleton_external.c b/engines/skeleton_external.c
index 9000accf..548676a7 100644
--- a/engines/skeleton_external.c
+++ b/engines/skeleton_external.c
@@ -37,8 +37,8 @@ static struct io_u *fio_skeleton_event(struct thread_data *td, int event)
  * which may then be retrieved by calling the ->event() hook with the event
  * numbers. Required.
  */
-static int fio_skeleton_getevents(struct thread_data *td, int min, int max,
-				  struct timespec *t)
+static int fio_skeleton_getevents(struct thread_data *td, unsigned int min,
+				  unsigned int max, struct timespec *t)
 {
 	return 0;
 }
@@ -59,11 +59,16 @@ static int fio_skeleton_cancel(struct thread_data *td, struct io_u *io_u)
  *
  * The io engine must transfer in the direction noted by io_u->ddir
  * to the buffer pointed to by io_u->xfer_buf for as many bytes as
- * io_u->xfer_buflen. Residual data count may be set in io_u->residual
+ * io_u->xfer_buflen. Residual data count may be set in io_u->resid
  * for a short read/write.
  */
 static int fio_skeleton_queue(struct thread_data *td, struct io_u *io_u)
 {
+	/*
+	 * Double sanity check to catch errant write on a readonly setup
+	 */
+	fio_ro_check(td, io_u);
+
 	/*
 	 * Could return FIO_Q_QUEUED for a queued request,
 	 * FIO_Q_COMPLETED for a completed request, and FIO_Q_BUSY