ASoC: cros_ec_codec: allocate shash_desc dynamically

[linux-2.6-block.git] / sound / soc / codecs / cros_ec_codec.c

diff --git a/sound/soc/codecs/cros_ec_codec.c b/sound/soc/codecs/cros_ec_codec.c
index d3dc42aa682565d34aaeb36798112688334f7107..1948bc6971f6ffafe4cc45f221cec2b0e764a057 100644 (file)
--- a/sound/soc/codecs/cros_ec_codec.c
+++ b/sound/soc/codecs/cros_ec_codec.c
@@ -108,22 +108,23 @@ static int calculate_sha256(struct cros_ec_codec_priv *priv,
                            uint8_t *buf, uint32_t size, uint8_t *digest)
 {
        struct crypto_shash *tfm;
+       struct shash_desc *desc;
 
        tfm = crypto_alloc_shash("sha256", CRYPTO_ALG_TYPE_SHASH, 0);
        if (IS_ERR(tfm)) {
                dev_err(priv->dev, "can't alloc shash\n");
                return PTR_ERR(tfm);
        }
-
-       {
-               SHASH_DESC_ON_STACK(desc, tfm);
-
-               desc->tfm = tfm;
-
-               crypto_shash_digest(desc, buf, size, digest);
-               shash_desc_zero(desc);
+       desc = kmalloc(sizeof(*desc) + crypto_shash_descsize(tfm), GFP_KERNEL);
+       if (!desc) {
+               crypto_free_shash(tfm);
+               return -ENOMEM;
        }
+       desc->tfm = tfm;
+       crypto_shash_digest(desc, buf, size, digest);
+       shash_desc_zero(desc);
 
+       kfree(desc);
        crypto_free_shash(tfm);
 
 #ifdef DEBUG